Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing all unnecessary console.log or changing them on console.error in the frontend code base #1423

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Removing all unnecessary console.log or changing them on console.error in the frontend code base #1423

merged 4 commits into from
Oct 16, 2024

Conversation

Michael-Kolpakov
Copy link
Contributor

Ticket

Code reviewers

Summary of issue

  • The code has accumulated a lot of console.log, which, apparently, were once created during the development process and were not deleted upon its completion.

Summary of change

  • Some console.log have been replaced with console.error, and some have been removed altogether.

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@Michael-Kolpakov Michael-Kolpakov self-assigned this Sep 18, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.5% Coverage on New Code (required ≥ 80%)
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Michael-Kolpakov Michael-Kolpakov merged commit f08c1ef into release/1.1.0 Oct 16, 2024
2 of 3 checks passed
@Michael-Kolpakov Michael-Kolpakov deleted the feature/issue-1742 branch October 16, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkravchuk darkravchuk darkravchuk approved these changes

@ulyasaur ulyasaur ulyasaur approved these changes

@mythter mythter mythter approved these changes

@sashapanasiuk5 sashapanasiuk5 Awaiting requested review from sashapanasiuk5

Assignees

@Michael-Kolpakov Michael-Kolpakov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Michael-Kolpakov @mythter @ulyasaur @darkravchuk